launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

Chris Johnston has proposed merging lp:~cjohnston/launchpad/883258 into lp:launchpad with lp:~cjohnston/launchpad/918284 as a prerequisite.

Commit message:
Increase the Ubuntu Mono font size for better readability.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #883258 in Launchpad itself: "Bug descriptions/comments much harder to read on Launchpad than other hosting services"
  https://bugs.launchpad.net/launchpad/+bug/883258

For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/883258/+merge/215332

Looking at the various platforms like GitHub, Google, and Gnome Bugzilla, it is much harder to read the text on Launchpad than it is on these other sites. This is caused by the design and use of the Ubuntu Mono font. A more detailed report about the differences is given in the bug. Adding the Ubuntu Mono web font to Launchpad allows for the Ubuntu Mono font size to be increased to a size where it has better readability.
-- 
https://code.launchpad.net/~cjohnston/launchpad/883258/+merge/215332
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/883258 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/css/modifiers.css'
--- lib/canonical/launchpad/icing/css/modifiers.css	2013-04-22 06:20:18 +0000
+++ lib/canonical/launchpad/icing/css/modifiers.css	2014-04-11 02:04:39 +0000
@@ -170,6 +170,7 @@
 .comment-text,
 .bug-activity {
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     }
 
 .cloud-size-smallest {

=== modified file 'lib/canonical/launchpad/icing/css/typography.css'
--- lib/canonical/launchpad/icing/css/typography.css	2012-09-12 01:36:22 +0000
+++ lib/canonical/launchpad/icing/css/typography.css	2014-04-11 02:04:39 +0000
@@ -42,6 +42,7 @@
     }
 pre, code, samp, tt, .console {
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     margin-bottom: 0.8em;
     }
 pre.wrap {

=== modified file 'lib/canonical/launchpad/icing/style.css'
--- lib/canonical/launchpad/icing/style.css	2013-09-05 03:57:28 +0000
+++ lib/canonical/launchpad/icing/style.css	2014-04-11 02:04:39 +0000
@@ -28,6 +28,7 @@
 div#edit-description,
 div#edit-commit_message {
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     margin: 1em 0;
     }
 
@@ -486,6 +487,7 @@
     border: solid gray;
     border-width: 1px;
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     border-radius: 5px;
 }
 

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2012-08-22 17:38:03 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2014-04-11 02:04:39 +0000
@@ -14,6 +14,7 @@
     }
     div#edit-recipe_text, div#edit-description {
       font-family: "Ubuntu Mono",monospace;
+      font-size: 14px;
       margin: 1em 0;
     }
     div#edit-recipe_text.yui3-editable_text-content,