launchpad-reviewers team mailing list archive

[Dimitri John Ledkov <launchpad@xxxxxxxxxxxx>]

Dimitri John Ledkov has proposed merging lp:~xnox/launchpad/fix-access-token-1 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1311029 in Launchpad itself: "OAuthAccessTokenView uses "body" signature type, instead of "header""
  https://bugs.launchpad.net/launchpad/+bug/1311029

For more details, see:
https://code.launchpad.net/~xnox/launchpad/fix-access-token-1/+merge/216693

untested =)
-- 
https://code.launchpad.net/~xnox/launchpad/fix-access-token-1/+merge/216693
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~xnox/launchpad/fix-access-token-1 into lp:launchpad.

=== modified file 'lib/lp/services/oauth/browser/__init__.py'
--- lib/lp/services/oauth/browser/__init__.py	2013-04-11 02:12:09 +0000
+++ lib/lp/services/oauth/browser/__init__.py	2014-04-22 10:41:47 +0000
@@ -416,7 +416,7 @@
         (or is not associated with the consumer), the signature does not match
         or no permission has been granted by the user, respond with a 401.
         """
-        form = self.request.form
+        form = get_oauth_authorization(self.request)        
         consumer = getUtility(IOAuthConsumerSet).getByKey(
             form.get('oauth_consumer_key'))