← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/builderset-new-api into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Wed, 23 Apr 2014 22:45:14 -0000
In-reply-to: <20140423111208.31901.64583.launchpad@ackee.canonical.com>
Reply-to: mp+216861@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good!

It seems to be a good compromise before re-thinking the buildmaster component for the Cloud(tm). However, since we do not have a remove() builders should be created with caution, even by Administrators.

-- 
https://code.launchpad.net/~wgrant/launchpad/builderset-new-api/+merge/216861
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/builderset-new-api into lp:launchpad
From: William Grant, 2014-04-23