launchpad-reviewers team mailing list archive

[Celso Providelo <celso.providelo@xxxxxxxxxxxxx>]

Review: Approve

Nice change! It makes the related navigation classes much simpler and saner.

We discussed the possibility to cleanup the DSPRNav() traversal to avoid the 'if not "a build in this context"' clause, but it would require a highly specific utility (DSPRBuild()) that would be only used in this callsite, so not worth the work.

Land it as it is, it already a much better place. 
-- 
https://code.launchpad.net/~wgrant/launchpad/archive-build-navigation/+merge/218363
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.