launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

On Tue, May 06, 2014 at 07:09:44PM +0100, Colin Watson wrote:
> My browser code (not yet committed) fails without this when trying to
> edit a LiveFS, as follows:

As discussed on IRC, this is because set_schema honours readonly.  There
doesn't seem to be a cleaner way to make this attribute writeable by the
application but readonly on the webservice.

> The "distro_series" name comes from the IPackageBuild interface, which
> I'm using basically because it has upload log handling.  What would you
> suggest I do here?  Reimplement upload log handling and inherit directly
> from IBuildFarmJob, perhaps?

I looked at doing this, but the bulk of the code in PackageBuildMixin
deals with handling upload logs, so there doesn't seem much point.  I
guess live filesystem builds aren't really package builds, but you could
argue that SPRBs kind of aren't either.

So, I guess my only remaining option for consistency is to rename
distroseries to distro_series and distroarchseries to distro_arch_series
throughout the livefs code (and the DB too, I suppose).  I dislike the
underscore-heavy names, but I don't see an alternative here.  Do you
agree?

-- 
https://code.launchpad.net/~cjwatson/launchpad/livefs/+merge/217261
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.