launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

Review: Resubmit



Inline comments:

> --- lib/canonical/launchpad/icing/style.css	2014-05-20 16:03:08 +0000
> +++ lib/canonical/launchpad/icing/style.css	2014-05-20 16:03:08 +0000
> @@ -584,6 +584,7 @@
>  table.diff {
>     white-space: pre-wrap;
>     width: 100%;
> +   table-layout: fixed;
>     background-color: white;
>     margin-bottom: 0.5em;
>  }
> @@ -593,17 +594,45 @@
>    background-color: #f6f6f6;
>    color: #999;
>    border-right: solid 4px white;
> +  width: 5%;
>  }
>  table.diff .line-no.active {
> -  background: url(/@@/edit) #f6f6f6 center left no-repeat;
> +  background: url(/@@/add) #f6f6f6 center left no-repeat;
>  }
>  table.diff .diff-chunk, table.diff .diff-file, table.diff .diff-header {
>   font-weight: bold;
>  }
>  table.diff .diff-added { background-color: #92ED92; }
>  table.diff .diff-removed { background-color: #FF7F7F; }
> -table.diff .inline-comments > td > div { margin: 0px 1em; }
> -
> +table.diff .inline-comments > td > div {
> +  margin: 0px 1em;
> +  word-wrap: break-word;
> +  font-family: monospace;
> +}
> +
> +table.diff .inline-comments .boardComment { width: 100%; }
> +

Gone.

> +table.diff .inline-comments .yui3-ieditor { padding-right:0!important; }
> +table.diff .yui3-ieditor-multiline .yui3-ieditor-btns .bg-top-label button.lazr-btn {
> +  text-indent: -9999px;
> +}
> +table.diff .yui3-ieditor-multiline .yui3-ieditor-btns .bg-top-label {

Without this, you see 'cancel' and 'ok' wih the X and check buttons.

> +  background-image: none!important;
> +  margin-right: -7px!important;
> +  margin-top: 18px!important;
> +}
> +table.diff .inline-comments .yui3-ieditor-input textarea {
> +  width: 92%;
> +  max-width: 92%;
> +  float: left;
> +}
> +table.diff .inline-comments .yui3-ieditor-input {
> +  width: auto!important;
> +  margin-right: 0;
> +  margin-bottom: 5px;
> +  overflow: hidden;
> +}
> +  
>  .back-link { margin-top: 3em; }
>  
>  .reviews {
> 


-- 
https://code.launchpad.net/~cjohnston/launchpad/ic-js-cleanup/+merge/220301
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.