launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #16799
Re: [Merge] lp:~cjohnston/launchpad/diff-return-text into lp:launchpad
Review: Approve
Chris, the change looks good and we can land it now and benefit from the wider audience feedback.
Later on, when re-structuring the whole JS code, it looks like we should move rc_scroller creation from DiffNav() to the PublishDraft() domain, where it is updated.
--
https://code.launchpad.net/~cjohnston/launchpad/diff-return-text/+merge/220954
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References