← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~wgrant/launchpad/non-js-link-regression into lp:launchpad

 

William Grant has proposed merging lp:~wgrant/launchpad/non-js-link-regression into lp:launchpad.

Commit message:
Fix regression non-JS CSS regression, where visited links were purple.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/non-js-link-regression/+merge/221395

Fix regression non-JS CSS regression, where visited links were purple. Missing commas in the landed version of CSS changes suck.
-- 
https://code.launchpad.net/~wgrant/launchpad/non-js-link-regression/+merge/221395
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/non-js-link-regression into lp:launchpad.
=== modified file 'lib/canonical/launchpad/icing/css/typography.css'
--- lib/canonical/launchpad/icing/css/typography.css	2014-05-28 20:38:48 +0000
+++ lib/canonical/launchpad/icing/css/typography.css	2014-05-29 14:37:32 +0000
@@ -50,15 +50,15 @@
     word-wrap: break-word;
     }
 
-:link, :visited a.js-action {
+:link, :visited, a.js-action {
     /* Links are blue, brighter when clicked, and greyer once visited. */
     color: #03a;
     text-decoration: none;
     }
-:link:hover, :visited:hover a.js-action {
+:link:hover, :visited:hover, a.js-action:hover {
     text-decoration: underline;
     }
-:link:active, :visited:active a.js-action:active {
+:link:active, :visited:active, a.js-action:active {
     color: #36c;
     }
 a[onclick], .collapsible legend a, a.js-action,


Follow ups