launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

Chris Johnston has proposed merging lp:~cjohnston/launchpad/bug-test-failures into lp:launchpad.

Commit message:
Fix bugs testing fallout

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/bug-test-failures/+merge/221467
-- 
https://code.launchpad.net/~cjohnston/launchpad/bug-test-failures/+merge/221467
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/bug-test-failures into lp:launchpad.

=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-activity.txt'
--- lib/lp/bugs/stories/bugs/xx-bug-activity.txt	2013-04-11 01:27:33 +0000
+++ lib/lp/bugs/stories/bugs/xx-bug-activity.txt	2014-05-29 23:07:57 +0000
@@ -228,7 +228,6 @@
     ... ago:
     #2
     Lookit, a change!
-    ...
     Changed in mozilla-firefox (Ubuntu):
     status:
     New => Confirmed
@@ -236,6 +235,7 @@
     Medium => Low
     status:
     Confirmed => New
+    Hide
     --------
 
 If a target of a bug task is changed the old and new value will be shown.
@@ -255,6 +255,7 @@
     ...
     affects:
     mozilla-firefox (Ubuntu) => linux-source-2.6.15 (Ubuntu)
+    Hide
     --------
 
 If a bug task is deleted the pillar no longer affected will be shown.

=== modified file 'lib/lp/bugs/stories/bugs/xx-remote-bug-comments.txt'
--- lib/lp/bugs/stories/bugs/xx-remote-bug-comments.txt	2013-05-09 08:53:01 +0000
+++ lib/lp/bugs/stories/bugs/xx-remote-bug-comments.txt	2014-05-29 23:07:57 +0000
@@ -29,9 +29,9 @@
 inlined, to make it clear that the comment will end up on the remote
 bug tracker.
 
-    >>> footer = remote_bug_comment.find(
-    ...     attrs={'class': 'boardCommentFooter'})
-    >>> print extract_text(footer)
+    >>> activity = remote_bug_comment.find(
+    ...     attrs={'class': 'boardCommentActivity'})
+    >>> print extract_text(activity)
     Reply on Debian Bug tracker...
 
 When javascript is not available, the link simply takes us to the
@@ -63,8 +63,8 @@
 mark the comment as 'awaiting synchronization' until it makes its way
 to the remote bug tracker.
 
-    >>> footer = new_bug_comment.find(attrs={'class': 'boardCommentFooter'})
-    >>> print extract_text(footer.findAll('td')[1])
+    >>> activity = new_bug_comment.find(attrs={'class': 'boardCommentActivity'})
+    >>> print extract_text(activity.findAll('td')[1])
     Awaiting synchronization
 
 When the comment is synchronized, it receives a remote comment id, and
@@ -107,7 +107,7 @@
     >>> anon_browser.open('http://bugs.launchpad.dev/redfish/+bug/15')
     >>> remote_bug_comment = find_tags_by_class(
     ...     anon_browser.contents, 'remoteBugComment', only_first=True)
-    >>> footer = remote_bug_comment.find(
-    ...     attrs={'class': 'boardCommentFooter'})
-    >>> 'Reply' in extract_text(footer)
+    >>> activity = remote_bug_comment.find(
+    ...     attrs={'class': 'boardCommentActivity'})
+    >>> 'Reply' in extract_text(activity)
     False