launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/prf-bin into lp:launchpad.

Commit message:
Let the product-release-finder find *.bin as well.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/prf-bin/+merge/221889

Let's resolve https://answers.launchpad.net/launchpad/+question/248718 by also considering '.bin' to be an interesting extension.
-- 
https://code.launchpad.net/~wgrant/launchpad/prf-bin/+merge/221889
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/prf-bin into lp:launchpad.

=== modified file 'lib/lp/registry/scripts/productreleasefinder/finder.py'
--- lib/lp/registry/scripts/productreleasefinder/finder.py	2013-06-20 05:50:00 +0000
+++ lib/lp/registry/scripts/productreleasefinder/finder.py	2014-06-03 14:28:41 +0000
@@ -58,12 +58,12 @@
     'sparc',
     ])
 flavor_pattern = re.compile(r"""
-    (~                                # Packaging target
-     |_[a-z][a-z]_[A-Z][A-Z]          # or language version
-     |_(%s)                           # or processor version
-     |[\.-](win32|OSX)                # or OS version
-     |\.(deb|noarch|rpm|dmg|exe|apk)  # or packaging version
-    ).*                               # to the end of the string
+    (~                                    # Packaging target
+     |_[a-z][a-z]_[A-Z][A-Z]              # or language version
+     |_(%s)                               # or processor version
+     |[\.-](win32|OSX)                    # or OS version
+     |\.(deb|noarch|rpm|dmg|exe|apk|bin)  # or packaging version
+    ).*                                   # to the end of the string
     """ % processors, re.VERBOSE)
 
 

=== modified file 'lib/lp/registry/tests/test_prf_finder.py'
--- lib/lp/registry/tests/test_prf_finder.py	2012-11-26 08:33:03 +0000
+++ lib/lp/registry/tests/test_prf_finder.py	2014-06-03 14:28:41 +0000
@@ -445,6 +445,8 @@
         self.assertEqual(version, '0.6')
         version = extract_version('u1f-google-1.2.4.apk')
         self.assertEqual(version, '1.2.4')
+        version = extract_version('unetbootin-linux-603.bin')
+        self.assertEqual(version, '603')
 
     def test_extract_version_name_with_uppercase(self):
         """Verify that the file's version is lowercases."""