launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

Chris Johnston has proposed merging lp:~cjohnston/launchpad/1325127 into lp:launchpad.

Commit message:
Remove 'Publish draft inline comments' from +reply page

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1325127 in Launchpad itself: "MP comment +reply page wrongly shows "Publish draft inline comments""
  https://bugs.launchpad.net/launchpad/+bug/1325127

For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/1325127/+merge/222085
-- 
https://code.launchpad.net/~cjohnston/launchpad/1325127/+merge/222085
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/1325127 into lp:launchpad.

=== modified file 'lib/lp/code/browser/codereviewcomment.py'
--- lib/lp/code/browser/codereviewcomment.py	2014-05-21 01:16:13 +0000
+++ lib/lp/code/browser/codereviewcomment.py	2014-06-04 18:19:22 +0000
@@ -23,10 +23,7 @@
     implements,
     Interface,
     )
-from zope.schema import (
-    Bool,
-    Text,
-    )
+from zope.schema import Text
 
 from lp import _
 from lp.app.browser.launchpadform import (
@@ -231,9 +228,6 @@
 
     comment = Text(title=_('Comment'), required=False)
 
-    publish_inline_comments = Bool(
-        title=_("Publish draft inline comments"), required=False)
-
 
 class CodeReviewCommentAddView(LaunchpadFormView):
     """View for adding a CodeReviewComment."""