launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

The proposal to merge lp:~wgrant/launchpad/ppa-reset-2.0-db into lp:launchpad/db-devel has been updated.

Description changed to:

Add new database columns to implement the Launchpad virtual builder reset protocol 2.0 for Scalingstack (described in https://docs.google.com/a/canonical.com/document/d/1SfJ9jA0_l_8iryANEkhe2HE5mMTRy-zcz6t_UBce7Vw/edit). VM resets in the new protocol are no longer synchronous during dispatching, but asynchronous before a dispatch is even considered, so we need to persist additional state.

The schema will evolve in future as our builder model grows cloudier, and with some luck the clean_status column will be dead before the year is out. But it remains to be seen exactly how it should be replaced, so it will do for now.

A new protocol version enum column has been added, as well as a clean_status column to track whether a slave is currently CLEAN, DIRTY or CLEANING. Wherever the cleanliness is in question, it fails safe to DIRTY. There's also a timestamp of the most recent clean_status change, to let us more easily track when things are stuck.

https://code.launchpad.net/~wgrant/launchpad/ppa-reset-2.0-model/+merge/223396 has the initial model code, and https://code.launchpad.net/~wgrant/launchpad/ppa-reset-2.0-basics/+merge/223397 ports the virt 1.1 and non-virt protocols to the new model.

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/ppa-reset-2.0-db/+merge/223395
-- 
https://code.launchpad.net/~wgrant/launchpad/ppa-reset-2.0-db/+merge/223395
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/ppa-reset-2.0-db into lp:launchpad/db-devel.