← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cprov/launchpad/create-spec-webservice into lp:launchpad

To: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Thu, 19 Jun 2014 02:24:27 -0000
In-reply-to: <20140617043423.19026.16516.launchpad@ackee.canonical.com>
Reply-to: mp+223332@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

You should export SpecSet.new as createSpecification rather than introducing a createSpecification that just directly invokes new, but otherwise this looks good now.
-- 
https://code.launchpad.net/~cprov/launchpad/create-spec-webservice/+merge/223332
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cprov/launchpad/create-spec-webservice into lp:launchpad
From: Celso Providelo, 2014-06-17