← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/preloadSpecificBuild-sort into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Mon, 23 Jun 2014 11:48:31 -0000
In-reply-to: <20140623104423.9958.34106.launchpad@ackee.canonical.com>
Reply-to: mp+224098@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Thanks for clarifying the groupby() unexpected behaviour on unsorted series (it generated extra groups on key transitions).
Sorting the series on the same key does fixes it.
-- 
https://code.launchpad.net/~wgrant/launchpad/preloadSpecificBuild-sort/+merge/224098
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/preloadSpecificBuild-sort into lp:launchpad
From: William Grant, 2014-06-23