launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad-buildd/livefs-ltsp into lp:launchpad-buildd.

Commit message:
Install ltsp-server (but not its Recommends) for livefs builds, as Edubuntu needs it.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-buildd/livefs-ltsp/+merge/224306

Edubuntu i386 builds have regressed with the new Launchpad-based builds because ltsp-build-client is unavailable in the chroot:

  https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/utopic/edubuntu/+build/97

This was previously only handled by make-chroot.sh in canonical-is-puppet installing ltsp-server in i386 livefs chroots, which was obscure enough that I didn't notice it.

I considered inventing a way for livefs jobs to request additional build-dependencies.  However, Stéphane pointed out that ltsp-server without its Recommends is tiny, so it doesn't seem worth it for this.
-- 
https://code.launchpad.net/~cjwatson/launchpad-buildd/livefs-ltsp/+merge/224306
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad-buildd/livefs-ltsp into lp:launchpad-buildd.

=== modified file 'buildlivefs'
--- buildlivefs	2014-06-15 23:40:27 +0000
+++ buildlivefs	2014-06-24 14:15:48 +0000
@@ -109,6 +109,10 @@
 
     def install(self):
         self.chroot(["apt-get", "-y", "install", "livecd-rootfs"])
+        self.chroot([
+            "apt-get", "-y", "--no-install-recommends", "install",
+            "ltsp-server",
+            ])
         if self.options.locale is not None:
             self.chroot([
                 "apt-get", "-y", "--install-recommends", "install",

=== modified file 'debian/changelog'
--- debian/changelog	2014-06-22 15:12:20 +0000
+++ debian/changelog	2014-06-24 14:15:48 +0000
@@ -1,3 +1,10 @@
+launchpad-buildd (124) UNRELEASED; urgency=medium
+
+  * Install ltsp-server (but not its Recommends) for livefs builds, as
+    Edubuntu needs it.
+
+ -- Colin Watson <cjwatson@xxxxxxxxxx>  Tue, 24 Jun 2014 14:58:16 +0100
+
 launchpad-buildd (123) hardy; urgency=medium
 
   * Fix handling of livefs builds for the -proposed pocket.