launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code

This consumes LFA and LFC IDs for each retry, which isn't totally bad, but it's also possibly silly. I'd consider just retrying the communication with the librarian server.

Additionally, I don't think this will actually work. file is never seeked back to the start, so I suspect that a retry after the file has been sent will just read from EOF and fail with a size mismatch. As discussed on IRC, it might be worth only retrying if we can file.seek(0).
-- 
https://code.launchpad.net/~cjwatson/launchpad/librarian-client-retry/+merge/224408
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.