← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wgrant/launchpad/dispatchBuildToSlave-common into lp:launchpad

 

Review: Approve

Thanks for being brave enough to start this refactoring, It is another step in the right direction.

It's worrying that we didn't have a P3A build dispatching test before, I am glad you took the opportunity for adding one.

I see no problems in landing this and postpone more refactoring and better coverage.
-- 
https://code.launchpad.net/~wgrant/launchpad/dispatchBuildToSlave-common/+merge/224389
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References