← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/handleStatus-crash into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Thu, 26 Jun 2014 13:23:24 -0000
In-reply-to: <20140626131223.5437.47207.launchpad@ackee.canonical.com>
Reply-to: mp+224617@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

No questioning, handleStatus() and children are much clearer and useful now. Thanks for dropping handleFailure() as well.

Another large step towards cleaner and more testable code.
-- 
https://code.launchpad.net/~wgrant/launchpad/handleStatus-crash/+merge/224617
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/handleStatus-crash into lp:launchpad
From: William Grant, 2014-06-26