← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/supports_mirrors-model into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Mon, 07 Jul 2014 11:43:47 -0000
In-reply-to: <20140707050922.17855.2926.launchpad@ackee.canonical.com>
Reply-to: mp+225771@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Nice strategy! Because my memory is not good as yours, I'd add an fat XXX in the IDistribution.supports_mirror implementation to not forget it's needs proper DB and UI support at some point.

-- 
https://code.launchpad.net/~wgrant/launchpad/supports_mirrors-model/+merge/225771
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/supports_mirrors-model into lp:launchpad
From: William Grant, 2014-07-07