launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/refactor-publishing-methods into lp:launchpad has been updated.

Description changed to:

Move some publishing methods out of the DistroSeries/DistroArchSeries model code and into archivepublisher.  This gets code out of the webapp that doesn't need to be there, and it will make it much easier to make a follow-up change to optimise the queries performed by phase A of the publisher; as it is, it's difficult to query all the pending publications at once because the queries are hidden behind separate method calls.

Unlike the previous layout, I made the new publishSources method not call publishBinaries itself.  This felt like it made more sense from the point of view of sensible method naming.  I don't think it's hugely important either way though.

ICanPublishPackages is no longer needed, and vanishes.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/refactor-publishing-methods/+merge/226050
-- 
https://code.launchpad.net/~cjwatson/launchpad/refactor-publishing-methods/+merge/226050
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/refactor-publishing-methods into lp:launchpad.