← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjohnston/launchpad/dd-initialization into lp:launchpad

 

The packageset_import widget isn't exactly choosing which packagesets to import; not every package is in a packageset, so choosing to copy ("import" isn't a term that Launchpad ever uses for copying packages internally) all packages does more than copy all the packagesets. I'd say it's the widget that chooses which packages to copy.

Consider "Don't copy any packages", "Copy all packages", "Copy some packagesets". It probably also makes sense to only show the packageset selection widget in the "some" case.
-- 
https://code.launchpad.net/~cjohnston/launchpad/dd-initialization/+merge/226796
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/dd-initialization into lp:launchpad.


Follow ups