launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code

This is looking good, but it needs tests.

I'd also consider dropping the else block; the if block skips the rest of the loop body anyway, so having the SQL in an else block just adds another level of avoidable indentation and obfuscates the diff.
-- 
https://code.launchpad.net/~cjohnston/launchpad/proper-pkg-link-copying/+merge/228000
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.