launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #17209
[Merge] lp:~wgrant/launchpad/expunge-daily-builds into lp:launchpad
William Grant has proposed merging lp:~wgrant/launchpad/expunge-daily-builds into lp:launchpad.
Commit message:
Remove remnants of the late +daily-builds view.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~wgrant/launchpad/expunge-daily-builds/+merge/228056
Remove remnants of the late +daily-builds view.
--
https://code.launchpad.net/~wgrant/launchpad/expunge-daily-builds/+merge/228056
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/expunge-daily-builds into lp:launchpad.
=== modified file 'lib/lp/code/javascript/tests/test_util.html'
--- lib/lp/code/javascript/tests/test_util.html 2012-10-26 09:54:28 +0000
+++ lib/lp/code/javascript/tests/test_util.html 2014-07-24 08:17:45 +0000
@@ -36,17 +36,6 @@
<div id="fixture"></div>
- <script type="text/x-template" id="daily-builds-form">
- <form name="filter" id="filter_form" action="/+test">
- <select id="field.when_completed_filter"
- name="field.when_completed_filter" size="1">
- <option selected="selected" value="ALL">All</option>
- <option value="WITHIN_30_DAYS">Recent</option>
- </select>
- <input id="filter_form_submit" type="submit" value="Filter"/>
- </form>
- </script>
-
<script type="text/x-template" id="branch-listing-form">
<form name="filter" id="filter_form" action="/+test">
<select id="field.lifecycle" name="field.lifecycle" size="1">
=== modified file 'lib/lp/code/javascript/tests/test_util.js'
--- lib/lp/code/javascript/tests/test_util.js 2013-03-20 03:41:40 +0000
+++ lib/lp/code/javascript/tests/test_util.js 2014-07-24 08:17:45 +0000
@@ -41,16 +41,6 @@
};
},
- test_hookUpDailyBuildsFilterSubmission: function() {
- this._setup_fixture('#daily-builds-form');
- module.hookUpDailyBuildsFilterSubmission();
- this._add_submit_listener('#filter_form');
- Y.one('[id="field.when_completed_filter"]').simulate('change');
- Y.Assert.isTrue(this.listener.event_fired);
- Y.Assert.isTrue(
- Y.one('#filter_form_submit').hasClass('hidden'));
- },
-
test_hookUpBranchFilterSubmission: function() {
this._setup_fixture('#branch-listing-form');
module.hookUpBranchFilterSubmission();
=== modified file 'lib/lp/code/javascript/util.js'
--- lib/lp/code/javascript/util.js 2012-07-07 14:00:30 +0000
+++ lib/lp/code/javascript/util.js 2014-07-24 08:17:45 +0000
@@ -44,12 +44,6 @@
Y.one('#filter_form_submit').addClass('hidden');
};
-var hookUpDailyBuildsFilterSubmission = function() {
- Y.one("[id='field.when_completed_filter']").on(
- 'change', submit_filter);
- Y.one('#filter_form_submit').addClass('hidden');
-};
-
var hookUpMergeProposalFilterSubmission = function() {
Y.one("[id='field.status']").on('change', submit_filter);
Y.one('#filter_form_submit').addClass('hidden');
@@ -66,7 +60,6 @@
ns.hookUpBranchFieldFunctions = hookUpBranchFieldFunctions;
ns.hookUpBranchFilterSubmission = hookUpBranchFilterSubmission;
-ns.hookUpDailyBuildsFilterSubmission = hookUpDailyBuildsFilterSubmission;
ns.hookUpMergeProposalFilterSubmission = hookUpMergeProposalFilterSubmission;
ns.hookUpRetyImportSubmission = hookUpRetyImportSubmission;
=== removed file 'lib/lp/code/templates/daily-builds-listing.pt'
--- lib/lp/code/templates/daily-builds-listing.pt 2012-06-15 16:23:50 +0000
+++ lib/lp/code/templates/daily-builds-listing.pt 1970-01-01 00:00:00 +0000
@@ -1,110 +0,0 @@
-<html
- xmlns="http://www.w3.org/1999/xhtml";
- xmlns:tal="http://xml.zope.org/namespaces/tal";
- xmlns:metal="http://xml.zope.org/namespaces/metal";
- xmlns:i18n="http://xml.zope.org/namespaces/i18n";
- metal:use-macro="view/macro:page/main_only"
- i18n:domain="launchpad">
-
- <body>
-
- <metal:heading fill-slot="heading">
- <h1 tal:content="view/page_title" />
- </metal:heading>
-
- <div metal:fill-slot="main"
- tal:define="dailybuilds view/batchnav/currentBatch">
-
- <form method="get" name="filter" id="filter_form"
- style="padding-bottom: 0.5em"
- tal:attributes="action view/form_action|request/URL">
- Show packages with a successful recipe <a
- href="https://help.launchpad.net/Packaging/SourceBuilds/GettingStarted";
- class="sprite maybe action-icon">(?)</a>build
- <tal:build-age-selector replace="structure view/widgets/when_completed_filter"/>
- <input id="filter_form_submit" type="submit" value="Filter"/>
- </form>
-
- <script type="text/javascript">
- LPJS.use("lp.code.util", function(Y) {
- Y.on("domready", function(e) {
- Y.lp.code.util.hookUpDailyBuildsFilterSubmission(Y);
- }, window);
- });
- </script>
-
- <tal:block tal:condition="not:dailybuilds">
- <p id="no-builds">No recently completed daily builds found.</p>
- </tal:block>
-
- <tal:block tal:condition="dailybuilds">
-
- <tal:needs-batch condition="view/batchnav/has_multiple_pages">
- <div class="lesser" tal:content="structure view/batchnav/@@+navigation-links-upper"/>
- </tal:needs-batch>
-
- <table tal:attributes="class view/batchnav/table_class" id="daily-build-listing">
- <thead>
- <tr>
- <th>
- Source Package
- </th>
- <th>
- Recipe
- </th>
- <th>
- Recipe Owner
- </th>
- <th>
- Archive
- </th>
- <th>
- Most Recent Build Time
- </th>
- </tr>
- </thead>
- <tbody>
- <tr tal:repeat="dailybuild dailybuilds">
- <td>
- <a tal:attributes="href dailybuild/distro_source_package/fmt:url"
- tal:content="dailybuild/sourcepackagename/name">source package name</a>
- </td>
-
- <td>
- <a href="recipe" tal:attributes="href dailybuild/recipe_url">
- <span tal:replace="dailybuild/recipe_name">
- recipe
- </span>
- </a>
- </td>
-
- <td>
- <tal:recipeowner replace="structure dailybuild/recipeowner/fmt:link">
- recipe owner
- </tal:recipeowner>
- </td>
-
- <td>
- <tal:archivelink tal:condition="dailybuild/archive/is_ppa"
- replace="structure dailybuild/archive/fmt:link">
- archive link
- </tal:archivelink>
- <tal:archive tal:condition="not:dailybuild/archive/is_ppa"
- replace="structure dailybuild/archive/displayname">
- archive name
- </tal:archive>
- </td>
-
- <td tal:content="dailybuild/most_recent_build_time/fmt:datetime">
- a date
- </td>
-
- </tr>
- </tbody>
- </table>
- <div class="lesser" tal:content="structure view/batchnav/@@+navigation-links-lower" />
- </tal:block>
- </div>
-
- </body>
-</html>
Follow ups
