launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/nu-overrides-adapters into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Tue, 29 Jul 2014 12:31:10 -0000
In-reply-to: <20140729085031.20532.63758.launchpad@ackee.canonical.com>
Reply-to: mp+228619@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Amazing how this new overriding mechanism is simplifying the code around it. Very nice design!

This change improves not only code readability but also correctness, great job.

As discussed on IRC, having proper overrides in NU will have good impacts in publications, possibly more cleanups (eg soyuz.model.publishing.get_component) and stop {S,B}PR component/section mutation (noted as XXX) and these effects will be explored in subsequent MPs.

-- 
https://code.launchpad.net/~wgrant/launchpad/nu-overrides-adapters/+merge/228619
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/nu-overrides-adapters into lp:launchpad
From: William Grant, 2014-07-29