launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code

Thanks for this, looks almost good to land. Just one thing: I'd go a step further with removing it from the model, hardcoding 'freshmeatproject = None' on Product and ProjectGroup in place of the StringCol(...) definition.

We don't need to store the data any more; we just need a value to fill the deprecated API field, and that might as well be None. Removing the column will prevent Storm from querying it, letting us clean up the DB without further code changes later down the line.
-- 
https://code.launchpad.net/~fmarier/launchpad/remove-freshmeat/+merge/233820
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.