launchpad-reviewers team mailing list archive

[Bayard Randel <kit@xxxxxxxxxxxxxxx>]

Bayard Randel has proposed merging lp:~brandel/launchpad/bug1383394 into lp:launchpad.

Commit message:
Series vocabulary no longer sorts pre-sorted list.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1383394 in Launchpad itself: "Ubuntu Project "Nominate for Series" is not alphabetically sorted"
  https://bugs.launchpad.net/launchpad/+bug/1383394

For more details, see:
https://code.launchpad.net/~brandel/launchpad/bug1383394/+merge/239197
-- 
https://code.launchpad.net/~brandel/launchpad/bug1383394/+merge/239197
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~brandel/launchpad/bug1383394 into lp:launchpad.

=== modified file 'lib/lp/bugs/vocabularies.py'
--- lib/lp/bugs/vocabularies.py	2013-06-20 05:50:00 +0000
+++ lib/lp/bugs/vocabularies.py	2014-10-22 14:06:27 +0000
@@ -264,9 +264,7 @@
     def __iter__(self):
         bug = self.context.bug
 
-        all_series = self._getNominatableObjects()
-
-        for series in sorted(all_series, key=attrgetter("displayname")):
+        for series in self._getNominatableObjects():
             if bug.canBeNominatedFor(series):
                 yield self.toTerm(series)