← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/bug-1315625 into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Thu, 23 Oct 2014 12:52:09 -0000
In-reply-to: <20141022204530.20699.75134.launchpad@ackee.canonical.com>
Reply-to: mp+239304@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

William,

Nice fix, but that searchForTerms implementation with a union on exact and like matches wasn't the easiest read of the day ;-) I am glad you master the use of ProductSet.getProductPrivacyFilter()

-- 
https://code.launchpad.net/~wgrant/launchpad/bug-1315625/+merge/239304
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/bug-1315625 into lp:launchpad
From: William Grant, 2014-10-22