launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/bpb-arch_indep-db into lp:launchpad/db-devel.

Commit message:
Add BinaryPackageBuild.arch_indep DB schema.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/bpb-arch_indep-db/+merge/240389

With vivid switching nominatedarchindep from i386 to amd64, the nominatedarchindep architecture needs to sometimes build arch-indep binaries, and sometimes not. This has to be judged at createMissingBuilds time, which means we need a way to persist it.

The new BinaryPackageBuild.arch_indep boolean column will be backfilled based on nominatedarchindep then made NOT NULL. Build dispatching will use the column rather than checking nominatedarchindep directly.
-- 
https://code.launchpad.net/~wgrant/launchpad/bpb-arch_indep-db/+merge/240389
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bpb-arch_indep-db into lp:launchpad/db-devel.

=== added file 'database/schema/patch-2209-59-0.sql'
--- database/schema/patch-2209-59-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-59-0.sql	2014-11-03 03:57:02 +0000
@@ -0,0 +1,8 @@
+-- Copyright 2014 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE binarypackagebuild ADD COLUMN arch_indep boolean;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 59, 0);