← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~wgrant/launchpad/dsspr-no-views into lp:launchpad

 

William Grant has proposed merging lp:~wgrant/launchpad/dsspr-no-views into lp:launchpad.

Commit message:
Drop all DistroSeriesSourcePackageRelease browser code, redirecting to DistributionSourcePackageRelease instead.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/dsspr-no-views/+merge/241218

Drop all DistroSeriesSourcePackageRelease browser code, redirecting to DistributionSourcePackageRelease instead.

Also add a changes file link to DSPR:+index, the one missing bit relative to DSSPR:+index.
-- 
https://code.launchpad.net/~wgrant/launchpad/dsspr-no-views/+merge/241218
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/dsspr-no-views into lp:launchpad.
=== modified file 'lib/lp/registry/browser/sourcepackage.py'
--- lib/lp/registry/browser/sourcepackage.py	2014-11-09 01:48:36 +0000
+++ lib/lp/registry/browser/sourcepackage.py	2014-11-09 23:09:44 +0000
@@ -87,8 +87,8 @@
 from lp.services.webapp import (
     ApplicationMenu,
     canonical_url,
-    GetitemNavigation,
     Link,
+    Navigation,
     StandardLaunchpadFacets,
     stepto,
     )
@@ -149,7 +149,7 @@
         return {'displayname': displayname}
 
 
-class SourcePackageNavigation(GetitemNavigation, BugTargetTraversalMixin):
+class SourcePackageNavigation(Navigation, BugTargetTraversalMixin):
 
     usedfor = ISourcePackage
 
@@ -188,6 +188,15 @@
         redirection_url = canonical_url(dsp, view_name='+gethelp')
         return self.redirectSubTree(redirection_url, status=303)
 
+    def traverse(self, name):
+        """Deprecated redirect to an IDistributionSourcePackageRelease.
+
+        IDistroSeriesSourcePackageRelease lived here until it was
+        removed in Nov 2014.
+        """
+        dspr = self.context.distribution_sourcepackage.getVersion(name)
+        return self.redirectSubTree(canonical_url(dspr), status=301)
+
 
 @adapter(ISourcePackage)
 class SourcePackageBreadcrumb(Breadcrumb):

=== modified file 'lib/lp/registry/browser/tests/test_distroseries.py'
--- lib/lp/registry/browser/tests/test_distroseries.py	2014-07-07 03:32:50 +0000
+++ lib/lp/registry/browser/tests/test_distroseries.py	2014-11-09 23:09:44 +0000
@@ -1293,8 +1293,7 @@
         self.assertEqual(1, len(links))
         self.assertEqual(versions['derived'], links[0].string.strip())
 
-        link = canonical_url(derived_series.getSourcePackageRelease(
-            difference.source_pub.sourcepackagerelease))
+        link = canonical_url(difference.source_package_release)
         self.assertTrue(link, EndsWith(new_version))
         # The link points to the sourcepackagerelease referenced in the
         # difference.

=== modified file 'lib/lp/soyuz/browser/configure.zcml'
--- lib/lp/soyuz/browser/configure.zcml	2014-11-09 00:48:47 +0000
+++ lib/lp/soyuz/browser/configure.zcml	2014-11-09 23:09:44 +0000
@@ -87,18 +87,6 @@
         for="lp.soyuz.interfaces.sourcepackagerelease.ISourcePackageRelease"
         permission="zope.Public">
         <browser:page
-            name="+portlet-builds"
-            template="../templates/sourcepackagerelease-portlet-builds.pt"/>
-        <browser:page
-            name="+portlet-details"
-            template="../templates/sourcepackagerelease-portlet-details.pt"/>
-        <browser:page
-            name="+portlet-distroseries"
-            template="../templates/sourcepackagerelease-portlet-distroseries.pt"/>
-        <browser:page
-            name="+portlet-details-content"
-            template="../templates/sourcepackagerelease-portlet-details-content.pt"/>
-        <browser:page
             name="+diffs"
             template="../templates/sourcepackagerelease-diffs.pt"/>
     </browser:pages>
@@ -156,31 +144,6 @@
             module="lp.soyuz.browser.publishing"
             classes="SourcePackagePublishingHistoryNavigation" />
     <browser:defaultView
-        for="lp.soyuz.interfaces.distroseriessourcepackagerelease.IDistroSeriesSourcePackageRelease"
-        name="+index"/>
-    <browser:url
-        for="lp.soyuz.interfaces.distroseriessourcepackagerelease.IDistroSeriesSourcePackageRelease"
-        path_expression="string:${version}"
-        attribute_to_parent="sourcepackage"/>
-    <browser:navigation
-        module="lp.soyuz.browser.distroseriessourcepackagerelease"
-        classes="
-            DistroSeriesSourcePackageReleaseNavigation"/>
-    <browser:pages
-        for="lp.soyuz.interfaces.distroseriessourcepackagerelease.IDistroSeriesSourcePackageRelease"
-        class="lp.soyuz.browser.distroseriessourcepackagerelease.DistroSeriesSourcePackageReleaseView"
-        permission="zope.Public">
-        <browser:page
-            name="+index"
-            template="../templates/distroseriessourcepackagerelease-index.pt"/>
-
-        <!-- DistroSeriesSourcePackageRelease Portlets -->
-
-        <browser:page
-            name="+portlet-details"
-            template="../templates/distroseriessourcepackagerelease-portlet-details.pt"/>
-    </browser:pages>
-    <browser:defaultView
         for="lp.soyuz.interfaces.distroarchseriesbinarypackagerelease.IDistroArchSeriesBinaryPackageRelease"
         name="+index"/>
     <browser:url

=== removed file 'lib/lp/soyuz/browser/distroseriessourcepackagerelease.py'
--- lib/lp/soyuz/browser/distroseriessourcepackagerelease.py	2011-12-24 17:49:30 +0000
+++ lib/lp/soyuz/browser/distroseriessourcepackagerelease.py	1970-01-01 00:00:00 +0000
@@ -1,64 +0,0 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
-# GNU Affero General Public License version 3 (see the file LICENSE).
-
-__metaclass__ = type
-
-__all__ = [
-    'DistroSeriesSourcePackageReleaseNavigation',
-    'DistroSeriesSourcePackageReleaseView',
-    ]
-
-from lazr.restful.utils import smartquote
-
-from lp.services.webapp import (
-    ApplicationMenu,
-    LaunchpadView,
-    Navigation,
-    stepthrough,
-    )
-from lp.soyuz.interfaces.distroseriessourcepackagerelease import (
-    IDistroSeriesSourcePackageRelease,
-    )
-
-
-class DistroSeriesSourcePackageReleaseOverviewMenu(ApplicationMenu):
-
-    usedfor = IDistroSeriesSourcePackageRelease
-    facet = 'overview'
-    links = []
-
-
-class DistroSeriesSourcePackageReleaseNavigation(Navigation):
-    usedfor = IDistroSeriesSourcePackageRelease
-
-    @stepthrough('+files')
-    def traverse_files(self, name):
-        """Traverse into a virtual +files subdirectory.
-
-        This subdirectory is special in that it redirects filenames that
-        match one of the SourcePackageRelease's files to the relevant
-        librarian URL. This allows it to be used with dget, as suggested
-        in https://bugs.launchpad.net/soyuz/+bug/130158
-        """
-        # If you are like me you'll ask yourself how it can be that we're
-        # putting this traversal on IDistroSeriesSourcePackageRelease and
-        # using it with sourcepackagerelease-files.pt. The reason is
-        # that the canonical_url for SourcePackageRelease is actually an
-        # IDistroSeriesSourcePackageRelease page. Weird.
-        for file in self.context.files:
-            if file.libraryfile.filename == name:
-                return file.libraryfile
-        return None
-
-
-class DistroSeriesSourcePackageReleaseView(LaunchpadView):
-
-    def __init__(self, context, request):
-        self.context = context
-        self.request = request
-
-    @property
-    def label(self):
-        return smartquote(self.context.title)
-
-    page_title = label

=== modified file 'lib/lp/soyuz/stories/packaging/package-pages-navigation.txt'
--- lib/lp/soyuz/stories/packaging/package-pages-navigation.txt	2011-11-25 16:51:29 +0000
+++ lib/lp/soyuz/stories/packaging/package-pages-navigation.txt	2014-11-09 23:09:44 +0000
@@ -104,29 +104,6 @@
     Main heading: ?alsa-utils? source package in Hoary
 
 
-== Distribution series source package release ==
-
-A distribution series source package release does not have its own
-Bugs, Translations, or anything else, so it is not part of the
-top-level hierarchy. Instead, the hierarchy stops at the distribution
-series source package.
-
-    >>> anon_browser.open(
-    ...     'http://launchpad.dev/ubuntu/hoary/'
-    ...     '+source/alsa-utils/1.0.9a-4ubuntu1')
-    >>> print_location(anon_browser.contents)
-    Hierarchy: Ubuntu > Hoary (5.04) > ?alsa-utils? source package
-    Tabs:
-    * Overview (selected) - http://launchpad.dev/ubuntu/hoary/+source/alsa-utils
-    * Code - http://code.launchpad.dev/ubuntu/hoary/+source/alsa-utils
-    * Bugs - http://bugs.launchpad.dev/ubuntu/hoary/+source/alsa-utils
-    * Blueprints - not linked
-    * Translations - http://translations.launchpad.dev/ubuntu/hoary/+source/alsa-utils
-    * Answers - not linked
-    Main heading: ?alsa-utils? 1.0.9a-4ubuntu1 source package in
-        The Hoary Hedgehog Release
-
-
 == Distribution series architecture ==
 
 Distribution series architectures pages inherit Code, Bugs, Blueprints and

=== modified file 'lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt'
--- lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt	2014-01-14 04:22:25 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt	2014-11-09 23:09:44 +0000
@@ -201,6 +201,7 @@
     Downloads
     File                  Size      MD5 Checksum
     testing-dspr_1.0.dsc  28 bytes  5913c3ad52c14a62e6ae7eef51f9ef42
+    View changes file
 
     >>> print anon_browser.getLink('testing-dspr_1.0.dsc').url
     http://.../ubuntutest/+archive/primary/+files/testing-dspr_1.0.dsc
@@ -225,6 +226,7 @@
     testing-dspr_1.0.dsc  28 bytes  5913c3ad52c14a62e6ae7eef51f9ef42
     Available diffs
     diff from 0.9 to 1.0 (7 bytes)
+    View changes file
 
     >>> print anon_browser.getLink('0.9 to 1.0').url
     http://.../101/testing-dspr_0.9_1.0.diff.gz

=== removed file 'lib/lp/soyuz/stories/soyuz/xx-distro-package-pages.txt'
--- lib/lp/soyuz/stories/soyuz/xx-distro-package-pages.txt	2014-11-09 01:46:17 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-distro-package-pages.txt	1970-01-01 00:00:00 +0000
@@ -1,52 +0,0 @@
-= Distribution Package Peculiarities =
-
-There are a number of pages for packages under the distribution
-hierarchy. This test verifies some peculiar features in that hierarchy.
-
-
-== $(distribution)/+source redirects home ==
-
-Check that going to $distribution/+source redirects to $distribution.
-
-  >>> browser.open("http://launchpad.dev/ubuntu/+source";)
-  >>> browser.url
-  'http://launchpad.dev/ubuntu'
-
-
-== DistroSeriesSourcePackageRelease offer dgettable URLs ==
-
-One useful tool for fetching source packages is dget, which pulls a DSC
-file and then grabs its dependencies. In Launchpad, we model a virtual
-directory under distro series source package release pages which
-actually redirects individual entries to librarian URLs.
-
-The commercial package lists three files:
-
-  >>> browser.open(
-  ...     'http://launchpad.dev/ubuntu/breezy-autotest/+source/'
-  ...     'commercialpackage/1.0-1')
-  >>> print extract_text(find_tag_by_id(browser.contents, 'files'))
-  File Size MD5 Checksum
-  commercialpackage_1.0.orig.tar.gz 179 bytes ...
-  commercialpackage_1.0-1.diff.gz 610 bytes ...
-  commercialpackage_1.0-1.dsc 567 bytes ...
-
-If you check out the URL for the DSC, you'll see it's in the +files
-virtual directory:
-
-  >>> file_link = browser.getLink("commercialpackage_1.0-1.dsc")
-  >>> print file_link.url
-  http://.../+files/commercialpackage_1.0-1.dsc
-
-  >>> from urlparse import urlsplit
-  >>> path = urlsplit(file_link.url)[2]
-
-And if you go to fetch it, you'll see it's actually a librarian URL:
-
-  >>> print http(r"""
-  ... GET %s HTTP/1.1
-  ... """ % path)
-  HTTP/1.1 303 See Other
-  ...
-  Location: http://.../68/commercialpackage_1.0-1.dsc
-  ...

=== modified file 'lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt'
--- lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt	2014-11-09 01:48:36 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt	2014-11-09 23:09:44 +0000
@@ -14,11 +14,11 @@
 
 $LP/ubuntu/$DISTRORELEASE/+source/$SOURCENAME
 
-A SourcePackageRelease once published in a DistroSeries is
-represented by a DistroSeriesSourcePackageRelease and easily reached
-by traversing a SourcePackage instance with a valid version, like:
+A SourcePackageRelease once published in a Distribution is represented
+by a DistributionSourcePackageRelease and easily reached by traversing a
+SourcePackage instance with a valid version, like:
 
-$LP/ubuntu/$DISTRORELEASE/+source/$SOURCENAME/$VERSION
+$LP/ubuntu/+source/$SOURCENAME/$VERSION
 
 The path to click here is a bit involved, since the source package
 page can only be reached by searching or getting a list of all
@@ -83,7 +83,9 @@
 The user can also download the files for the "currentrelease" (last
 published version) if they are available:
 
-  >>> print extract_text(find_tag_by_id(content, 'files'))
+  >>> print extract_text(find_portlet(
+  ...     content, 'Download files from current release (0.9)'))
+  Download files from current release (0.9)
   File Size MD5 Checksum
   firefox_0.9.2.orig.tar.gz 9.5 MiB ...
 
@@ -237,11 +239,13 @@
   >>> browser.url
   'http://launchpad.dev/ubuntu/+source/mozilla-firefox/0.9'
 
-There's also a very similar view that's being phased out:
-DistroSeriesSourcePackageRelease:+index.
+The deprecated DistroSeriesSourcePackageRelease page redirects to the
+same place.
 
   >>> browser.open(
   ...     'http://launchpad.dev/ubuntu/warty/+source/mozilla-firefox/0.9')
+  >>> browser.url
+  'http://launchpad.dev/ubuntu/+source/mozilla-firefox/0.9'
 
 There we can see the respective 'changelog' content for this version:
 
@@ -251,13 +255,14 @@
 
 With the possibility to download the entire changesfile (if available):
 
-  >>> print extract_text(find_tag_by_id(browser.contents, 'changesfile'))
-  View changes file
+  >>> print browser.getLink('View changes file').url
+  http://.../52/mozilla-firefox_0.9_i386.changes
 
 And also download the files contained in this source, like '.orig',
 '.diff' and the DSC:
 
-  >>> print extract_text(find_tag_by_id(browser.contents, 'files'))
+  >>> print extract_text(find_portlet(browser.contents, 'Downloads'))
+  Downloads
   File Size MD5 Checksum
   firefox_0.9.2.orig.tar.gz 9.5 MiB ...
 
@@ -268,7 +273,7 @@
 linkified.
 
   >>> browser.open(
-  ...  'http://launchpad.dev/ubuntu/warty/+source/alsa-utils/1.0.9a-4ubuntu1')
+  ...  'http://launchpad.dev/ubuntu/+source/alsa-utils/1.0.9a-4ubuntu1')
 
 This changelog has got text of the form 'LP: #nnn' where nnn is a bug number,
 and this is linkified so that when clicked it takes us to the bug page:
@@ -281,25 +286,24 @@
 the profile page for that person:
 
   >>> user_browser.open(
-  ...     "http://launchpad.dev/ubuntu/breezy-autotest/+source/";
-  ...     "commercialpackage/1.0-1")
+  ...     "http://launchpad.dev/ubuntu/+source/commercialpackage/1.0-1";)
   >>> print user_browser.getLink('foo.bar@xxxxxxxxxxxxx').url
   http://launchpad.dev/~name16
 
 Let's check how the page behaves if we no files are present:
 
   >>> browser.open(
-  ...     'http://launchpad.dev/ubuntu/hoary/+source/cnews/cr.g7-37')
+  ...     'http://launchpad.dev/ubuntu/+source/cnews/cr.g7-37')
 
+The Downloads portlet indicates that no files are available.
 A string is presented in both 'changesfile' and 'files' sections,
 warning the user that no file is available:
 
-  >>> print extract_text(find_tag_by_id(browser.contents, 'changesfile'))
+  >>> print extract_text(find_portlet(browser.contents, 'Downloads'))
+  Downloads
+  No files available for download.
   No changes file available.
 
-  >>> print extract_text(find_tag_by_id(browser.contents, 'files'))
-  No files available for download.
-
 
 DistroSeries Partner Source Package Pages
 =========================================
@@ -324,7 +328,9 @@
 The user can also download the files for the "currentrelease" (last
 published version) if they are available:
 
-    >>> print extract_text(find_tag_by_id(browser.contents, 'files'))
+    >>> print extract_text(find_portlet(
+    ...     browser.contents, 'Download files from current release (1.0-1)'))
+    Download files from current release (1.0-1)
     File Size MD5 Checksum
     commercialpackage_1.0.orig.tar.gz 179 bytes ...
     commercialpackage_1.0-1.diff.gz 610 bytes ...
@@ -389,13 +395,6 @@
     >>> browser.url
     'http://launchpad.dev/ubuntu/+source/commercialpackage/1.0-1'
 
-The DistroSeriesSourcePackageRelease view also works for partner
-packages, but it's being phased out.
-
-    >>> browser.open(
-    ...     'http://launchpad.dev/ubuntu/breezy-autotest/+source/'
-    ...     'commercialpackage/1.0-1')
-
 There we can see the respective 'changelog' content for this version:
 
     >>> tag = find_tag_by_id(browser.contents, 'commercialpackage_1.0-1')
@@ -410,7 +409,8 @@
 And also download the files contained in this source, like '.orig',
 '.diff' and the DSC:
 
-    >>> print extract_text(find_tag_by_id(browser.contents, 'files'))
+    >>> print extract_text(find_portlet(browser.contents, 'Downloads'))
+    Downloads
     File Size MD5 Checksum
     commercialpackage_1.0.orig.tar.gz 179 bytes ...
     commercialpackage_1.0-1.diff.gz 610 bytes ...

=== modified file 'lib/lp/soyuz/stories/soyuz/xx-private-builds.txt'
--- lib/lp/soyuz/stories/soyuz/xx-private-builds.txt	2014-07-24 09:37:03 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-private-builds.txt	2014-11-09 23:09:44 +0000
@@ -328,20 +328,6 @@
     >>> print browser.title
     i386 build of privacy-test 666 : PPA named p3a for Celso Providelo : Celso Providelo
 
-When accessing the distroseries source package release page, the builds
-portlet will display a link to the newly unembargoed build:
-
-    >>> browser.open(
-    ...     "http://launchpad.dev/ubuntutest/breezy-autotest/";
-    ...     "+source/privacy-test/666")
-    >>> portlet = find_portlet(browser.contents, 'Builds')
-    >>> print extract_text(portlet)
-    Builds
-    breezy-autotest i386 Successfully built
-
-    >>> print browser.getLink('i386').url
-    http://launchpad.dev/~cprov/+archive/ubuntu/p3a/+build/...
-
 Similarly, when accessing the distribution source package release page,
 the main content will display a link to the newly unembargoed build:
 

=== modified file 'lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt'
--- lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt	2011-08-28 08:36:14 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt	2014-11-09 23:09:44 +0000
@@ -94,7 +94,7 @@
 Browsing the individual sourcepackage changelog.
 
     >>> user_browser.open(
-    ...    "http://launchpad.dev/ubuntu/hoary/+source/alsa-utils/1.0.9a-4ubuntu1";)
+    ...    "http://launchpad.dev/ubuntu/+source/alsa-utils/1.0.9a-4ubuntu1";)
 
 The changelog is still linkified here so that the bug links work,
 although the version link will point to the same page we're already on.

=== modified file 'lib/lp/soyuz/templates/distributionsourcepackagerelease-index.pt'
--- lib/lp/soyuz/templates/distributionsourcepackagerelease-index.pt	2014-11-09 00:48:47 +0000
+++ lib/lp/soyuz/templates/distributionsourcepackagerelease-index.pt	2014-11-09 23:09:44 +0000
@@ -145,6 +145,13 @@
    <tal:diffs
      replace="structure context/sourcepackagerelease/@@+diffs"
      >Diffs...</tal:diffs>
+
+   <p tal:condition="context/upload_changesfile">
+     <a tal:attributes="href context/upload_changesfile/http_url">
+       View changes file
+     </a>
+   </p>
+   <p tal:condition="not: context/upload_changesfile">No changes file available.</p>
   </div> <!-- source-files -->
 
   <div id="source-binaries" class="portlet">

=== removed file 'lib/lp/soyuz/templates/distroseriessourcepackagerelease-index.pt'
--- lib/lp/soyuz/templates/distroseriessourcepackagerelease-index.pt	2014-11-09 00:48:47 +0000
+++ lib/lp/soyuz/templates/distroseriessourcepackagerelease-index.pt	1970-01-01 00:00:00 +0000
@@ -1,61 +0,0 @@
-<html
-  xmlns="http://www.w3.org/1999/xhtml";
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  metal:use-macro="view/macro:page/main_only"
-  i18n:domain="launchpad"
->
-  <body>
-
-<div metal:fill-slot="main">
-
-  <ul class="horizontal">
-    <li>
-      <a tal:replace="structure context/sourcepackage/menu:overview/distribution_source_package/fmt:link" />
-    </li>
-  </ul>
-
-  <div class="portlet">
-    <h2>Publishing history</h2>
-
-    <div id="publishing_history">
-      <tal:block repeat="publishing context/publishing_history"
-                replace="structure publishing/@@+listing-detailed">
-      </tal:block>
-    </div>
-  </div>
-
-  <div class="yui-g">
-
-    <div class="first yui-u">
-      <div tal:replace="structure context/@@+portlet-distroseries" />
-      <div class="portlet">
-        <h2>Download</h2>
-        <div id="files"
-             tal:content="structure context/distributionsourcepackagerelease/@@+files" />
-      </div>
-    </div>
-
-    <div class="yui-u" tal:content="structure context/@@+portlet-builds" />
-
-  </div>
-
-  <div class="portlet">
-    <h2>Changelog</h2>
-     <tal:pre
-          replace="structure context/@@+changelog" />
-  </div>
-
-   <div id="changesfile" tal:define="changesfile context/changesfile">
-     <p tal:condition="changesfile">
-        <a tal:attributes="href changesfile/http_url">
-           View changes file
-        </a>
-     </p>
-     <p tal:condition="not: changesfile">No changes file available.</p>
-   </div>
-
-</div>
-</body>
-</html>

=== removed file 'lib/lp/soyuz/templates/distroseriessourcepackagerelease-portlet-details.pt'
--- lib/lp/soyuz/templates/distroseriessourcepackagerelease-portlet-details.pt	2012-07-06 06:02:33 +0000
+++ lib/lp/soyuz/templates/distroseriessourcepackagerelease-portlet-details.pt	1970-01-01 00:00:00 +0000
@@ -1,20 +0,0 @@
-<div
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  class="portlet" id="portlet-details">
-
-  <h2>"<span tal:replace="context/name">apache2</span> 
-  <span tal:replace="context/version">2.0.39</span>" (source)
-  in <span tal:replace="context/distribution/name">ubuntu</span></h2>
-
-    <b>Series:</b>
-    <a tal:attributes="href context/distroseries/fmt:url">
-      <span tal:replace="context/distribution/name">ubuntu</span>
-      <span tal:replace="context/distroseries/name">hoary</span>
-    </a><br />
-    <b>Pocket:</b>
-    <span tal:replace="context/pocket/title">Release</span><br />
-    <div tal:replace="structure context/sourcepackagerelease/@@+portlet-details-content" />
-
-</div>

=== removed file 'lib/lp/soyuz/templates/sourcepackagerelease-portlet-builds.pt'
--- lib/lp/soyuz/templates/sourcepackagerelease-portlet-builds.pt	2012-07-06 06:02:33 +0000
+++ lib/lp/soyuz/templates/sourcepackagerelease-portlet-builds.pt	1970-01-01 00:00:00 +0000
@@ -1,27 +0,0 @@
-<tal:root
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  omit-tag="">
-
-<div class="portlet" id="portlet-builds" tal:condition="context/builds">
-
-  <h2>Builds</h2>
-
-    <ul>
-      <li tal:repeat="build context/builds">
-        <a tal:attributes="href build/fmt:url">
-          <span tal:replace="build/distro_arch_series/distroseries/name">
-            hoary
-          </span>
-          <span tal:content="build/distro_arch_series/architecturetag">i386</span>
-        </a>
-        <span tal:replace="build/status/title">Failure</span>
-        <span tal:condition="build/package_upload">
-          (<span tal:replace="build/package_upload/status/name">NEW</span>)
-        </span>
-      </li>
-    </ul>
-
-</div>
-</tal:root>

=== removed file 'lib/lp/soyuz/templates/sourcepackagerelease-portlet-details-content.pt'
--- lib/lp/soyuz/templates/sourcepackagerelease-portlet-details-content.pt	2012-03-10 15:08:09 +0000
+++ lib/lp/soyuz/templates/sourcepackagerelease-portlet-details-content.pt	1970-01-01 00:00:00 +0000
@@ -1,40 +0,0 @@
-<tal:root
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  omit-tag="">
-
-<tal:comment replace="nothing">
-  This is here so that these details can be re-used in all the
-  distr*sourcepackagerelease classes
-</tal:comment>
-<b>Uploaded By:</b>
-<a tal:replace="structure context/creator/fmt:link">Foo Bar</a><br />
-
-<b>Maintainer:</b>
-<a tal:replace="structure context/maintainer/fmt:link">Foo Bar</a><br />
-
-<b>Maintainer defaults:</b><sup>*</sup><br />
-<div style="margin-left: 10px;">
-  <b>Urgency:</b>
-  <span tal:replace="context/urgency/title">High</span><br />
-
-  <b>Component:</b>
-  <span tal:replace="context/component/name">main</span><br />
-
-  <b>Architectures:</b>
-  <span tal:replace="context/architecturehintlist">i386, ppc</span><br />
-</div>
-<div class="lesser">
-<sup>*</sup> actual publishing details may vary in this distribution, these
-are just the package defaults.
-</div>
-
-<b>Initially uploaded to:</b><br />
-<a tal:content="context/upload_distroseries/distribution/displayname"
-   tal:attributes="href context/upload_distroseries/distribution/fmt:url"
-   >Ubuntu</a>
-<a tal:content="context/upload_distroseries/displayname"
-   tal:attributes="href context/upload_distroseries/fmt:url"
-   >Warty</a>
-</tal:root>

=== removed file 'lib/lp/soyuz/templates/sourcepackagerelease-portlet-details.pt'
--- lib/lp/soyuz/templates/sourcepackagerelease-portlet-details.pt	2012-07-06 06:02:33 +0000
+++ lib/lp/soyuz/templates/sourcepackagerelease-portlet-details.pt	1970-01-01 00:00:00 +0000
@@ -1,15 +0,0 @@
-<tal:root
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  omit-tag="">
-
-<div class="portlet" id="portlet-details">
-
-  <h2><span tal:replace="context/title">source package "foobar"
-  2.3.1-2</span></h2>
-
-  <div tal:replace="structure context/@@+portlet-details-content" />
-
-</div>
-</tal:root>

=== removed file 'lib/lp/soyuz/templates/sourcepackagerelease-portlet-distroseries.pt'
--- lib/lp/soyuz/templates/sourcepackagerelease-portlet-distroseries.pt	2012-07-06 06:02:33 +0000
+++ lib/lp/soyuz/templates/sourcepackagerelease-portlet-distroseries.pt	1970-01-01 00:00:00 +0000
@@ -1,24 +0,0 @@
-<tal:root
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  omit-tag="">
-
-<div class="portlet" id="portlet-series">
-
-  <h2>Published in</h2>
-
-    <ul tal:condition="context/current_publishings">
-      <li class="package-source"
-          tal:repeat="drspr context/current_publishings">
-        <a class="sprite" tal:attributes="href drspr/fmt:url">
-          <span tal:replace="drspr/distribution/name">ubuntu</span>
-          <span tal:replace="drspr/distroseries/name">hoary</span>
-        </a>
-      </li>
-    </ul>
-    <p tal:condition="not: context/current_publishings">
-      <i>Not published anywhere yet.</i>
-    </p>
-</div>
-</tal:root>


Follow ups