launchpad-reviewers team mailing list archive

[Bayard 'kit' Randel <kit.randel@xxxxxxxxxxxxx>]

The proposal to merge lp:~blr/launchpad/inline-diff-comment-keybind into lp:launchpad has been updated.

Description changed to:

Summary
Users have suggested that when providing multiple inline diff comments, it is easy to forget to save an initial comment, before moving on. This is a small quality of life improvement, providing the shortcut Ctrl+Enter in the editor, and a relevant tooltip.

Proposed fix
This does not address the issue directly, but given programmers tend to be very keyboard oriented, providing a shortcut for saving a comment will generally improve workflow and reduce frustrations with the limitations around multiple editor states. Allowing for multiple editors in concurrent editing states should potentially be considered in a later MP.

Implementation details
The editor's keydown event now calls widget.editor.save() on ctrl+enter.

Tests
The test for this feature can be run using the standard yui test runner:
xvfb-run ./bin/test -x -cvv --layer=YUITestLayer

Demo and Q/A
Hit Ctrl+Enter in a BMP diff inline editor to save a comment.

For more details, see:
https://code.launchpad.net/~blr/launchpad/inline-diff-comment-keybind/+merge/243087
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.