launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/unhelp-pane into lp:launchpad.

Commit message:
Drop the invisible help-pane iframe that exists at the top left of every Launchpad page.

Requested reviews:
  William Grant (wgrant): code
Related bugs:
  Bug #295254 in Launchpad itself: "The popup help system should not use an <iframe> defined as inline HTML."
  https://bugs.launchpad.net/launchpad/+bug/295254

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/unhelp-pane/+merge/243117

Drop the invisible help-pane iframe that exists at the top left of every Launchpad page. It's been unused since inlinehelp was ported to YUI in 2012.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== removed file 'lib/canonical/launchpad/icing/css/components/help_pane.css'
--- lib/canonical/launchpad/icing/css/components/help_pane.css	2012-06-21 13:01:53 +0000
+++ lib/canonical/launchpad/icing/css/components/help_pane.css	1970-01-01 00:00:00 +0000
@@ -1,62 +0,0 @@
-/* =========================
-   Universal
-   Help pane
-*/
-.invisible {
-    left: -9999em;
-    display: block;
-    }
-
-#help-pane {
-    /* Inline help is dynamically positioned by JavaScript.
-       This should appear above all other content.  Needs to be
-       above the Google Maps element on the profile pages, which
-       has a z-index of 9999.  See bug #380349. */
-    position: absolute;
-    border: 1px solid black;
-    padding: 1px 1px 5px 10px;
-    z-index: 11000;
-    background-color: #fff;
-    width: 600px; /* based on the help wiki, should change later */
-    }
-
-#help-pane.invisible {
-    /* We want the hidden pane to have dimensions so that we can position the
-       frame with them.  This works because the element an absolute position,
-       taking it out of the page flow. */
-    position: absolute;
-    visibility: hidden;
-    display: block;
-    left: 0px;
-    top: 0px;
-    }
-
-#help-body {
-    background: url(/@@/spinner) no-repeat center center;
-    }
-
-#help-pane iframe {
-    width: 100%;
-    height: 300px;
-    border: 0;
-    }
-
-#help-pane iframe.invisible {
-    visibility: hidden;
-    display: block;
-    }
-
-#help-footer {
-    padding: 3px;
-    border-top: 1px solid #ddd;
-    text-align: right;
-    }
-
-#help-footer button {
-    margin-bottom: 10px;
-    margin-top: 3px;
-    }
-
-span.help {
-    font-weight: normal;
-    }

=== modified file 'lib/lp/app/browser/tests/test_base_layout.py'
--- lib/lp/app/browser/tests/test_base_layout.py	2014-11-27 08:49:35 +0000
+++ lib/lp/app/browser/tests/test_base_layout.py	2014-11-28 06:55:52 +0000
@@ -101,8 +101,6 @@
         self.assertEqual(
             'yui-main', yui_layout.find(True, id='maincontent')['class'])
         self.assertEqual(
-            'invisible', document.find(True, id='help-pane')['class'])
-        self.assertEqual(
             'footer', yui_layout.find(True, id='footer')['class'])
 
     def verify_watermark(self, document):

=== modified file 'lib/lp/app/templates/base-layout.pt'
--- lib/lp/app/templates/base-layout.pt	2014-11-25 19:59:57 +0000
+++ lib/lp/app/templates/base-layout.pt	2014-11-28 06:55:52 +0000
@@ -160,23 +160,6 @@
         use-macro="context/@@+base-layout-macros/footer"/>
     </div><!-- yui-d0-->
 
-    <div id="help-pane" class="invisible">
-      <div id="help-body">
-        <tal:XXX condition="nothing">
-          # XXX mars 2008-11-07 bug=295254:
-          # We use this ugly src="" hack to get rid of an IE6 security
-          # warning.  See bug #295234.
-        </tal:XXX>
-        <iframe
-          id="help-pane-content"
-          class="invisible"
-          src="javascript:void(0);"></iframe>
-      </div>
-      <div id="help-footer">
-        <span id="help-close"></span>
-      </div>
-    </div>
-
     <metal:lp-client-cache
       use-macro="context/@@+base-layout-macros/lp-client-cache" />
     <metal:debug-timeline