launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

On 09/01/15 10:32, Thomi Richards wrote:
> Done, although both 'if' statements need to check '.isdigit()',
> because we don't want to redirect on "#123 foobar" (as per bug
> comments).

  >>> "123 foo".isdigit()
  False

We don't need to duplicate the isdigit() check, we just want to skip a
leading # if it exists. I'm pretty sure the code I suggested is fine,
and much clearer.


-- 
https://code.launchpad.net/~thomir/launchpad/devel-fix-bug-redirect/+merge/245816
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.