← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjwatson/launchpad/zope.tales-upgrade into lp:launchpad

 

Yes it does, in a sense that if a readonly property is not set on creation time it would never have a value during the object lifetime, but in this case it's a derived value, as long as 'country' is required we are, theoretically, correct. Either way, I agree with your assessment that "required" is not important for properties due to the current field validation and its consistency is already debatable in other places in our codebase.

Let's just not block this landing because of it. Thanks for clarifying your points.
-- 
https://code.launchpad.net/~cjwatson/launchpad/zope.tales-upgrade/+merge/247030
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References