launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/drop-yui-array-extras into lp:launchpad.

Commit message:
Drop YUI array-extras module from a couple of files that no longer need it with YUI >= 3.5.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1052618 in Launchpad itself: "choice.js does not require array-extras with YUI 3.5"
  https://bugs.launchpad.net/launchpad/+bug/1052618

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/drop-yui-array-extras/+merge/250253

As Aaron noted in https://bugs.launchpad.net/launchpad/+bug/1052618, choice.js no longer requires array-extras now that we're on YUI >= 3.5, and I believe the same is true for expander.js too.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/drop-yui-array-extras into lp:launchpad.

=== modified file 'lib/lp/app/javascript/choice.js'
--- lib/lp/app/javascript/choice.js	2012-09-20 19:36:13 +0000
+++ lib/lp/app/javascript/choice.js	2015-02-19 03:30:59 +0000
@@ -195,11 +195,6 @@
         legacy_node, field_name, choices, cfg, get_fn, set_fn);
 };
 
-/* XXX: AaronBentley 2012-09-18 bug=1052618 array-extras needed to enable
- * Y.Array.forEach in YUI 3.3, but not needed in 3.5
- */
-
 }, "0.1", {
-    requires: ["lp.ui.choiceedit", "lp.client.plugins", "node-event-simulate",
-               "array-extras"]
+    requires: ["lp.ui.choiceedit", "lp.client.plugins", "node-event-simulate"]
 });

=== modified file 'lib/lp/app/javascript/expander.js'
--- lib/lp/app/javascript/expander.js	2012-09-11 14:30:45 +0000
+++ lib/lp/app/javascript/expander.js	2015-02-19 03:30:59 +0000
@@ -424,5 +424,5 @@
 namespace.createByCSS = createByCSS;
 
 }, "0.1", {
-    "requires": ["array-extras", "base", "event", "node", "lp.ui.effects"]
+    "requires": ["base", "event", "node", "lp.ui.effects"]
 });