launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/testfix-git-basic-model into lp:launchpad.

Commit message:
IProduct.createGitRepository requires launchpad.View now, not launchpad.Edit.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/testfix-git-basic-model/+merge/250366

IProduct.createGitRepository requires launchpad.View now, not launchpad.Edit.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/registry/tests/test_product.py'
--- lib/lp/registry/tests/test_product.py	2015-02-06 15:29:45 +0000
+++ lib/lp/registry/tests/test_product.py	2015-02-19 19:34:03 +0000
@@ -843,11 +843,11 @@
             'bugtracker', 'canUserAlterAnswerContact', 'codehosting_usage',
             'coming_sprints', 'commercial_subscription',
             'commercial_subscription_is_due', 'createBug',
-            'createCustomLanguageCode', 'custom_language_codes',
-            'date_next_suggest_packaging', 'datecreated', 'description',
-            'development_focus', 'development_focusID',
-            'direct_answer_contacts', 'distrosourcepackages',
-            'downloadurl', 'driver',
+            'createCustomLanguageCode', 'createGitRepository',
+            'custom_language_codes', 'date_next_suggest_packaging',
+            'datecreated', 'description', 'development_focus',
+            'development_focusID', 'direct_answer_contacts',
+            'distrosourcepackages', 'downloadurl', 'driver',
             'enable_bugfiling_duplicate_search', 'findReferencedOOPS',
             'findSimilarFAQs', 'findSimilarQuestions', 'freshmeatproject',
             'getAllowedBugInformationTypes',
@@ -902,8 +902,7 @@
         'launchpad.Edit': set((
             'addOfficialBugTag', 'removeOfficialBugTag',
             'setBranchSharingPolicy', 'setBugSharingPolicy',
-            'setSpecificationSharingPolicy', 'checkInformationType',
-            'createGitRepository')),
+            'setSpecificationSharingPolicy', 'checkInformationType')),
         'launchpad.Moderate': set((
             'is_permitted', 'license_approved', 'project_reviewed',
             'reviewer_whiteboard', 'setAliases')),