launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/git-basic-browser into lp:launchpad.

Commit message:
Catch all possible exceptions from IGitTraverser.traverse.

Requested reviews:
  Colin Watson (cjwatson)
Related bugs:
  Bug #1032731 in Launchpad itself: "Support for Launchpad-hosted Git repositories"
  https://bugs.launchpad.net/launchpad/+bug/1032731

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/git-basic-browser/+merge/251895

Catch all possible exceptions from IGitTraverser.traverse.  Fixes two test failures.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2015-03-04 16:49:42 +0000
+++ lib/lp/registry/browser/person.py	2015-03-05 10:34:21 +0000
@@ -186,7 +186,10 @@
     )
 from lp.registry.interfaces.pillar import IPillarNameSet
 from lp.registry.interfaces.poll import IPollSubset
-from lp.registry.interfaces.product import IProduct
+from lp.registry.interfaces.product import (
+    InvalidProductName,
+    IProduct,
+    )
 from lp.registry.interfaces.ssh import (
     ISSHKeySet,
     SSHKeyAdditionError,
@@ -396,7 +399,7 @@
                     return self.redirectSubTree(canonical_url(repository))
 
             return repository
-        except (NotFoundError, InvalidNamespace):
+        except (NotFoundError, InvalidNamespace, InvalidProductName):
             pass
 
         # If the pillar is a product, then return the PersonProduct; if it