← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wgrant/turnip/no-buildout into lp:turnip

 

Review: Approve

As discussed on IRC, we need to pull cffi, pycparser, and pygit2 out of requirements.txt (and possibly into a separate requirements file) to avoid making charm deployment depend on having a matching version of libgit2-dev on the deployment system.  Other than that this seems fine.
-- 
https://code.launchpad.net/~wgrant/turnip/no-buildout/+merge/252692
Your team Launchpad code reviewers is subscribed to branch lp:turnip.


References