launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

(Sorry for taking ages to come back to this.)

I don't understand how that would work.  LP_DEBUG_SQL is only read when creating instances of LaunchpadStatementTracer, which happens relatively late.  We can't wipe it in the generic testrunner code because that makes it impossible to use LP_DEBUG_SQL to debug Launchpad tests.  The reason that I think this belongs in TacTestSetup is that it's specifically about the interaction between a Launchpad-specific facility (LP_DEBUG_SQL) and a check performed by TacTestFixture (that the subprocess is quiet on stdout/stderr).

The only other way I can think of to do this would be to create another layer on top of TacTestSetup to clean up the environment and have all the tests that currently use TacTestSetup use that new class instead.  That doesn't seem to gain us anything at all.
-- 
https://code.launchpad.net/~cjwatson/launchpad/tachandler-debug-sql/+merge/217228
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.