launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/git-notify-celery-dup into lp:launchpad.

Commit message:
Remove duplicate celery scheduling of GitRefScanJobs on notify.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/git-notify-celery-dup/+merge/254795

Remove duplicate celery scheduling of GitRefScanJobs on notify.

This may be the cause of https://oops.canonical.com/?oopsid=OOPS-c059ce97509d37184be07e3ab8b3cc56, although I'm not sure yet.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/code/xmlrpc/git.py'
--- lib/lp/code/xmlrpc/git.py	2015-03-31 04:29:24 +0000
+++ lib/lp/code/xmlrpc/git.py	2015-03-31 16:38:51 +0000
@@ -246,8 +246,7 @@
         if repository is None:
             return faults.NotFound(
                 "No repository found for '%s'." % translated_path)
-        job = getUtility(IGitRefScanJobSource).create(repository)
-        job.celeryRunOnCommit()
+        getUtility(IGitRefScanJobSource).create(repository)
 
     def authenticateWithPassword(self, username, password):
         """See `IGitAPI`."""