launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code

Having a security-relevant autodetect the type of its input string doesn't seem like a very safe idea. Could you make the OpenID and name options separate and explicit? There aren't too many callsites that use strings.
-- 
https://code.launchpad.net/~cjwatson/launchpad/code-xmlrpc-openid/+merge/255506
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.