launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/testfix-git-reviewer into lp:launchpad.

Commit message:
Restore Branch.reviewer assignment in test factory, and remove redundant GitRepository.reviewer assignment.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/testfix-git-reviewer/+merge/256605

Restore Branch.reviewer assignment in test factory, and remove redundant GitRepository.reviewer assignment.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/testing/factory.py'
--- lib/lp/testing/factory.py	2015-04-15 21:33:25 +0000
+++ lib/lp/testing/factory.py	2015-04-16 23:38:00 +0000
@@ -1129,6 +1129,8 @@
             naked_branch.branchChanged(
                 removeSecurityProxy(stacked_on).unique_name, 'rev1', None,
                 None, None)
+        if reviewer is not None:
+            naked_branch.reviewer = reviewer
         return branch
 
     def makePackagingLink(self, productseries=None, sourcepackagename=None,
@@ -1685,8 +1687,6 @@
         if information_type is not None:
             naked_repository.transitionToInformationType(
                 information_type, registrant, verify_policy=False)
-        if reviewer is not None:
-            naked_repository.reviewer = reviewer
         return repository
 
     def makeGitRefs(self, repository=None, paths=None):