← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~blr/turnip/api-init-with-alternates into lp:turnip

 

Review: Needs Fixing code

The initial use case for alternates is to diff between repositories. So we'd planned to be able to have a diff request generate an ephemeral repo that exists only until the diff is complete, rather than having to work out some garbage collection strategy.

It's a bit more complicated to do that, because the path hierarchy needs to be able to specify multiple repo names. I was thinking something like /repo-union/$SOME_REPO/$OTHER_REPO/$ANY_PATH_THAT_WOULD_BE_A_REPO. You then need to construct the repo before actually executing the diff, and then destroy it afterwards.

Since we're using string-based routes, it may make sense to use /repo/SOME_REPO:OTHER_REPO/ and have the repo opener automatically generate an ephemeral repo.
-- 
https://code.launchpad.net/~blr/turnip/api-init-with-alternates/+merge/256715
Your team Launchpad code reviewers is subscribed to branch lp:turnip.


References