launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/git-ref-listing-names into lp:launchpad.

Commit message:
Use name rather than display_name on IGitRef:+index and IGitRefBatchNavigator:+ref-listing.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/git-ref-listing-names/+merge/257776

A couple of pages look weird now that GitRef.display_name includes the repository name.  That makes sense in places such as merge proposals where we want to render a ref on its own without an obvious repository context, but it looks a little odd on GitRef:+index where the repository is linked alongside it, and downright peculiar in branch listings.  GitRef.name will do for these cases.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/git-ref-listing-names into lp:launchpad.

=== modified file 'lib/lp/code/templates/gitref-index.pt'
--- lib/lp/code/templates/gitref-index.pt	2015-04-28 16:39:15 +0000
+++ lib/lp/code/templates/gitref-index.pt	2015-04-29 15:11:46 +0000
@@ -29,7 +29,7 @@
       <div class="two-column-list">
         <dl id="name">
           <dt>Name:</dt>
-          <dd tal:content="context/display_name" />
+          <dd tal:content="context/name" />
         </dl>
 
         <dl id="repository">

=== modified file 'lib/lp/code/templates/gitref-listing.pt'
--- lib/lp/code/templates/gitref-listing.pt	2015-03-24 14:56:57 +0000
+++ lib/lp/code/templates/gitref-listing.pt	2015-04-29 15:11:46 +0000
@@ -36,7 +36,7 @@
       <tr tal:repeat="ref context/currentBatch">
         <td>
           <a tal:attributes="href ref/fmt:url"
-             tal:content="structure ref/display_name/fmt:break-long-words" />
+             tal:content="structure ref/name/fmt:break-long-words" />
         </td>
         <tal:no_commit condition="not: ref/committer_date">
           <td colspan="2">