launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-gitnamespace-markers into lp:launchpad.

Commit message:
Remove the ##GITNAMESPACE## markers, now that we're on production.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/remove-gitnamespace-markers/+merge/258046

Now that we're on production and have a stable URL format, there isn't much point in having the ##GITNAMESPACE## markers any more.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/remove-gitnamespace-markers into lp:launchpad.

=== modified file 'lib/lp/code/interfaces/gitnamespace.py'
--- lib/lp/code/interfaces/gitnamespace.py	2015-04-28 23:25:08 +0000
+++ lib/lp/code/interfaces/gitnamespace.py	2015-05-01 15:38:18 +0000
@@ -188,7 +188,6 @@
         return getUtility(IGitNamespaceSet).get(owner)
 
 
-# Marker for references to Git URL layouts: ##GITNAMESPACE##
 def split_git_unique_name(unique_name):
     """Return the namespace and repository names of a unique name."""
     try:

=== modified file 'lib/lp/code/interfaces/gitrepository.py'
--- lib/lp/code/interfaces/gitrepository.py	2015-04-28 16:39:15 +0000
+++ lib/lp/code/interfaces/gitrepository.py	2015-05-01 15:38:18 +0000
@@ -350,7 +350,6 @@
         More important related objects are sorted first.
         """
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     def getRepositoryIdentities():
         """A list of aliases for a repository.
 
@@ -566,7 +565,6 @@
             to the target's code sharing policy.  (optional)
         """
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     @call_with(user=REQUEST_USER)
     @operation_parameters(
         path=TextLine(title=_("Repository path"), required=True))

=== modified file 'lib/lp/code/model/gitlookup.py'
--- lib/lp/code/model/gitlookup.py	2015-03-30 14:47:22 +0000
+++ lib/lp/code/model/gitlookup.py	2015-05-01 15:38:18 +0000
@@ -74,7 +74,6 @@
 
     implements(IGitTraversable)
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     def traverse(self, owner, name, segments):
         """See `IGitTraversable`.
 
@@ -107,7 +106,6 @@
     def __init__(self, context):
         self.context = context
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     def traverse(self, owner, name, segments):
         """See `IGitTraversable`.
 
@@ -152,7 +150,6 @@
     adapts(IDistribution)
     implements(IGitTraversable)
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     def traverse(self, owner, name, segments):
         """See `IGitTraversable`.
 
@@ -204,7 +201,6 @@
     def getNamespace(self, owner):
         return getUtility(IGitNamespaceSet).get(owner)
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     def traverse(self, owner, name, segments):
         """See `IGitTraversable`.
 

=== modified file 'lib/lp/code/model/gitnamespace.py'
--- lib/lp/code/model/gitnamespace.py	2015-04-28 23:25:08 +0000
+++ lib/lp/code/model/gitnamespace.py	2015-05-01 15:38:18 +0000
@@ -249,7 +249,6 @@
             GitRepository.distribution == None,
             GitRepository.sourcepackagename == None)
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     @property
     def name(self):
         """See `IGitNamespace`."""
@@ -324,7 +323,6 @@
             GitRepository.owner == self.owner,
             GitRepository.project == self.project)
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     @property
     def name(self):
         """See `IGitNamespace`."""
@@ -411,7 +409,6 @@
             GitRepository.distribution == dsp.distribution,
             GitRepository.sourcepackagename == dsp.sourcepackagename)
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     @property
     def name(self):
         """See `IGitNamespace`."""

=== modified file 'lib/lp/code/model/gitrepository.py'
--- lib/lp/code/model/gitrepository.py	2015-04-28 16:39:15 +0000
+++ lib/lp/code/model/gitrepository.py	2015-05-01 15:38:18 +0000
@@ -209,7 +209,6 @@
         self.owner_default = False
         self.target_default = False
 
-    # Marker for references to Git URL layouts: ##GITNAMESPACE##
     @property
     def unique_name(self):
         names = {"owner": self.owner.name, "repository": self.name}