launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/turnip/enable-pack-bitmaps into lp:turnip.

Commit message:
Set repack.writeBitmaps to true before any write operation.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/turnip/enable-pack-bitmaps/+merge/258371

Now that we have the infrastructure for setting config options, it's trivial to switch on pack bitmap indices as well.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/turnip/enable-pack-bitmaps into lp:turnip.

=== modified file 'turnip/pack/helpers.py'
--- turnip/pack/helpers.py	2015-05-01 21:20:22 +0000
+++ turnip/pack/helpers.py	2015-05-06 11:48:16 +0000
@@ -107,6 +107,7 @@
 
     config = Repository(repo_root).config
     config['core.logallrefupdates'] = True
+    config['repack.writeBitmaps'] = True
 
 
 def ensure_hooks(repo_root):

=== modified file 'turnip/pack/tests/test_helpers.py'
--- turnip/pack/tests/test_helpers.py	2015-05-06 11:45:18 +0000
+++ turnip/pack/tests/test_helpers.py	2015-05-06 11:48:16 +0000
@@ -180,6 +180,7 @@
         helpers.ensure_config(self.repo_dir)
         config = Config(path=self.config_path)
         self.assertTrue(config['core.logallrefupdates'])
+        self.assertTrue(config['repack.writeBitmaps'])
 
     def test_writes_new(self):
         self.assertWritesCorrectConfig()
@@ -201,6 +202,8 @@
             f.write(dedent("""\
                 [core]
                 \tlogallrefupdates = false
+                [repack]
+                \twriteBitmaps = false
                 """))
         self.assertWritesCorrectConfig()