launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/build-logs-utf-8 into lp:launchpad.

Commit message:
Serve build logs as UTF-8.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/build-logs-utf-8/+merge/258474

Serve build logs as UTF-8.

We can't guarantee that it's the case, but it's most likely to be correct, and of increasing importance with a modern sbuild that uses graphical characters.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/build-logs-utf-8 into lp:launchpad.

=== modified file 'lib/lp/services/librarian/utils.py'
--- lib/lp/services/librarian/utils.py	2012-01-01 02:58:52 +0000
+++ lib/lp/services/librarian/utils.py	2015-05-07 10:09:26 +0000
@@ -69,7 +69,7 @@
     """
     if filename.endswith('txt.gz'):
         encoding = 'gzip'
-        mimetype = 'text/plain'
+        mimetype = 'text/plain; charset=utf-8'
     elif filename.endswith('diff.gz'):
         encoding = 'gzip'
         mimetype = 'text/plain'