launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/copier-logging into lp:launchpad.

Commit message:
Pass a logger to the package copier script.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/copier-logging/+merge/259482

PlainPackageCopyJob doesn't pass a logger down to the copier script, so we miss out on a few bits of debug logging.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/copier-logging into lp:launchpad.

=== modified file 'lib/lp/soyuz/model/packagecopyjob.py'
--- lib/lp/soyuz/model/packagecopyjob.py	2014-08-14 09:54:33 +0000
+++ lib/lp/soyuz/model/packagecopyjob.py	2015-05-19 10:35:20 +0000
@@ -660,7 +660,8 @@
             send_email=send_email, announce_from_person=self.requester,
             sponsored=self.sponsored, packageupload=pu,
             unembargo=self.unembargo,
-            phased_update_percentage=self.phased_update_percentage)
+            phased_update_percentage=self.phased_update_percentage,
+            logger=self.logger)
 
         # Add a PackageDiff for this new upload if it has ancestry.
         if copied_publications and not ancestry.is_empty():