← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~blr/launchpad/inline-comment-nav into lp:launchpad

 

The blur works if you save the comment with Ctrl+Enter, but clicking the save button focuses that instead. Perhaps it's best to just document.activeElement.blur()?

The first hunk bug is still there if there are no comments to start with. Load a fresh diff, press H, be surprised that you're on the first hunk header. Interestingly, that doesn't happen if you delete all of the comments but don't refresh the page. It's probably falling through the "case 'comment':" which lacks a break in the case that comment_idx isn't set.
-- 
https://code.launchpad.net/~blr/launchpad/inline-comment-nav/+merge/260427
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References