launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/git-process-mail into lp:launchpad.

Commit message:
Allow processmail DB user to access the GitRepository table, so that incoming mail for Git-based merge proposals works.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/git-process-mail/+merge/260959

Allow processmail DB user to access the GitRepository table, so that incoming mail for Git-based merge proposals works.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/git-process-mail into lp:launchpad.

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2015-06-01 17:10:53 +0000
+++ database/schema/security.cfg	2015-06-03 14:39:36 +0000
@@ -1778,6 +1778,7 @@
 public.emailaddress                     = SELECT
 public.faq                              = SELECT
 public.flatpackagesetinclusion          = SELECT
+public.gitrepository                    = SELECT
 public.gpgkey                           = SELECT
 public.job                              = SELECT, INSERT, UPDATE
 public.karma                            = SELECT, INSERT

=== modified file 'lib/lp/code/mail/tests/test_codehandler.py'
--- lib/lp/code/mail/tests/test_codehandler.py	2014-06-10 16:13:03 +0000
+++ lib/lp/code/mail/tests/test_codehandler.py	2015-06-03 14:39:36 +0000
@@ -163,6 +163,17 @@
             '<my-id>', [comment.message.rfc822msgid
                         for comment in bmp.all_comments])
 
+    def test_process_git(self):
+        """Processing an email related to a Git-based merge proposal works."""
+        mail = self.factory.makeSignedMessage('<my-id>')
+        bmp = self.factory.makeBranchMergeProposalForGit()
+        email_addr = bmp.address
+        switch_dbuser(config.processmail.dbuser)
+        self.code_handler.process(mail, email_addr, None)
+        self.assertIn(
+            '<my-id>',
+            [comment.message.rfc822msgid for comment in bmp.all_comments])
+
     def test_processBadAddress(self):
         """When a bad address is supplied, it returns False."""
         mail = self.factory.makeSignedMessage('<my-id>')