launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

target_default and owner_default are a bit weird to show on a form like this. target_default can only be set by a few people, and there will be project-level UI for that. I don't know where the personal default flag should be set, but it makes a little more sense on this form as it can be used by anyone who can edit the repo.

There's also the issue that they only make sense for non-personal targets, though the JS makes that semi-clear by disabling them.

I'd consider replacing the ancient onKeyPress inline JS with proper stuff.
-- 
https://code.launchpad.net/~cjwatson/launchpad/git-repository-ui-edit-target/+merge/261232
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.